Implement rule for unserialize
#4754
Open
+250
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
force-pushed
the
feature/unserialize
branch
2 times, most recently
from
d868abd to
0bf9e38
Compare
eliashaeussler
commented
Jan 14, 2026
| $this->analyse([__DIR__ . '/data/unserialize.php'], $expectedErrors); | ||
| } | ||
|
|
||
| #[RequiresPhp('< 7.4')] |
Author
There was a problem hiding this comment.
I'm not sure whether to keep this test case, since it does not seem like PHP < 7.4 is actually included in the test matrix.
eliashaeussler
force-pushed
the
feature/unserialize
branch
from
0bf9e38 to
548c158
Compare
ondrejmirtes
force-pushed
the
feature/unserialize
branch
from
548c158 to
a089725
Compare
ondrejmirtes
requested changes
Feb 10, 2026
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
Two things:
- This is a new rule, should only be enabled with bleeding edge using conditionalTags in config.
- Some things this rule reports should be achieved by changing resources/functionMap files (the deltas) - this will make existing rule to pick up the errors. I'm thinking about:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new rule for
unserialize. Following behaviors will trigger an error:checkInsecureUnserialize: true)allowed_classesnormax_depth)allowed_classes'allowed_classes' => true(only with parametercheckInsecureUnserialize: true)allowed_classesmax_depthkey on PHP < 7.4max_depthallowed_classesconfigured (only with parametercheckInsecureUnserialize: true)